kamalcph commented on code in PR #13837: URL: https://github.com/apache/kafka/pull/13837#discussion_r1261600532
########## storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageHistory.java: ########## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.log.remote.storage; + +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.server.log.remote.storage.LocalTieredStorageEvent.EventType; +import org.slf4j.Logger; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.function.Predicate; +import java.util.stream.Collectors; + +import static java.util.Arrays.stream; +import static java.util.Collections.unmodifiableMap; +import static java.util.function.Function.identity; +import static java.util.stream.Collectors.toMap; +import static org.slf4j.LoggerFactory.getLogger; + +/** + * Accumulates and retains the interactions between brokers and {@link LocalTieredStorage} instances. + * These interactions are modelled via events of type {@link LocalTieredStorageEvent}. + * + * Events from an instance of storage are captured by the {@link LocalTieredStorageHistory} after + * {@link LocalTieredStorageHistory#listenTo(LocalTieredStorage)} is called. + */ +/* @ThreadSafe */ +public final class LocalTieredStorageHistory { Review Comment: yes, you're right. History is maintained only in memory and to assert the interaction with the `RemoteStorageManager`. No plans made so far to make it durable. This framework is mainly used to assert the functionality end-to-end instead of stress-test where there can be a huge number of events for a single test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
