DL1231 commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1263167540
########## core/src/main/scala/kafka/server/ReplicaManager.scala: ########## @@ -526,14 +532,17 @@ class ReplicaManager(val config: KafkaConfig, /** * Stop the given partitions. * - * @param partitionsToStop A map from a topic partition to a boolean indicating - * whether the partition should be deleted. + * @param partitionsToStop A map from a topic partition to a boolean indicating + * whether the partition should be deleted. + * @param partitionsMaybeToDeleteRemote A set of topic partitions that may need to delete + * remote segments. * - * @return A map from partitions to exceptions which occurred. - * If no errors occurred, the map will be empty. + * @return A map from partitions to exceptions which occurred. + * If no errors occurred, the map will be empty. */ protected def stopPartitions( - partitionsToStop: Map[TopicPartition, Boolean] + partitionsToStop: Map[TopicPartition, Boolean], Review Comment: Yes, this pr doesn't support KRaft mode, we could create a new jira to address this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org