cmccabe commented on code in PR #13643:
URL: https://github.com/apache/kafka/pull/13643#discussion_r1264232306
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1076,10 +1073,10 @@ public void handleLeaderChange(LeaderAndEpoch
newLeader) {
renounce();
}
} else if (newLeader.isLeader(nodeId)) {
- log.info("Becoming the active controller at epoch {},
committed offset {}, " +
- "committed epoch {}", newLeader.epoch(),
lastCommittedOffset,
- lastCommittedEpoch);
- claim(newLeader.epoch());
+ long newLastWriteOffset = endOffset - 1;
Review Comment:
The endOffset comes directly from the log and is as described... the end
offset (exclusive).
Thinking about it more, I don't think I need to assume that it's committed,
so I won't.
But it is used to calculate the next offset that the active controller
should try to write to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
