Owen-CH-Leung commented on code in PR #13773:
URL: https://github.com/apache/kafka/pull/13773#discussion_r1265218200
##########
metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java:
##########
@@ -44,9 +46,30 @@ public void testSetMetadataVersion() {
setMetadataVersion(version);
if (i < MetadataVersion.MINIMUM_BOOTSTRAP_VERSION.ordinal()) {
assertEquals(MetadataVersion.MINIMUM_KRAFT_VERSION,
options.metadataVersion());
+ assertEquals(version, options.requestedMetadataVersion());
} else {
assertEquals(version, options.metadataVersion());
}
}
}
+
+ @Test
+ public void testHandleLoss() {
+ String expectedMessage = "stuff";
+
+ for (int i = MetadataVersion.MINIMUM_KRAFT_VERSION.ordinal();
+ i < MetadataVersion.VERSIONS.length;
+ i++) {
+ MetadataVersion version = MetadataVersion.VERSIONS[i];
+ String formattedMessage = String.format("Metadata has been lost
because the following could not be represented in metadata version %s: %s",
version, expectedMessage);
+ Consumer<UnwritableMetadataException> customLossHandler = e -> {
+ assertEquals(formattedMessage, e.getMessage());
+ };
Review Comment:
ahh yes. Removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
