lianetm commented on code in PR #13990:
URL: https://github.com/apache/kafka/pull/13990#discussion_r1265611455
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Utils.java:
##########
@@ -17,13 +17,175 @@
package org.apache.kafka.clients.consumer.internals;
import java.io.Serializable;
+import java.util.Collections;
import java.util.Comparator;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.kafka.clients.ApiVersions;
+import org.apache.kafka.clients.ClientUtils;
+import org.apache.kafka.clients.CommonClientConfigs;
+import org.apache.kafka.clients.GroupRebalanceConfig;
+import org.apache.kafka.clients.Metadata;
+import org.apache.kafka.clients.NetworkClient;
+import org.apache.kafka.clients.consumer.ConsumerConfig;
+import org.apache.kafka.clients.consumer.ConsumerInterceptor;
+import org.apache.kafka.clients.consumer.OffsetResetStrategy;
+import org.apache.kafka.common.IsolationLevel;
import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.metrics.KafkaMetricsContext;
+import org.apache.kafka.common.metrics.MetricConfig;
+import org.apache.kafka.common.metrics.Metrics;
+import org.apache.kafka.common.metrics.MetricsContext;
+import org.apache.kafka.common.metrics.MetricsReporter;
+import org.apache.kafka.common.metrics.Sensor;
+import org.apache.kafka.common.serialization.Deserializer;
+import org.apache.kafka.common.serialization.StringDeserializer;
+import org.apache.kafka.common.utils.LogContext;
+import org.apache.kafka.common.utils.Time;
public final class Utils {
+ public static final String CONSUMER_JMX_PREFIX = "kafka.consumer";
+ public static final String CONSUMER_METRIC_GROUP_PREFIX = "consumer";
+
+ /**
+ * A fixed, large enough value will suffice for max.
+ */
+ public static final int CONSUMER_MAX_INFLIGHT_REQUESTS_PER_CONNECTION =
100;
+
+ private static final String CONSUMER_CLIENT_ID_METRIC_TAG = "client-id";
+
+ public static ConsumerNetworkClient
createConsumerNetworkClient(ConsumerConfig config,
Review Comment:
We are adding all these consumer-related utility functions to this Utils
class, that was previously used only for partition comparators, needed for
assignment/group coordination. Any reason why we want the new logic here? Maybe
better in a separate class for consumer-specific utils?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
