jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1265816192
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -299,10 +299,10 @@ public CompletableFuture<JoinGroupResponseData> joinGroup(
topicPartitionFor(request.groupId()),
coordinator -> coordinator.genericGroupJoin(context, request,
responseFuture)
).exceptionally(exception -> {
- log.error("Request {} hit an unexpected exception: {}",
- request, exception.getMessage());
-
if (!responseFuture.isDone()) {
+ log.error("Request {} hit an unexpected exception: {}",
Review Comment:
ah makes sense. logging only when it is not a kafka exception makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
