tanay27 commented on code in PR #14035:
URL: https://github.com/apache/kafka/pull/14035#discussion_r1266542795
##########
release.py:
##########
@@ -692,7 +700,7 @@ def select_gpg_key():
fail("Ok, giving up")
if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag):
fail("Ok, giving up")
-cmd("Pushing RC tag", "git push %s %s" % (PUSH_REMOTE_NAME, rc_tag))
+cmd("Pushing RC tag", f"git push {PUSH_REMOTE_NAME} {rc_tag}")
Review Comment:
Writing it, I wanted to get an opinion on if we can use new way of string
formatting. This is better for readability than the other two methods.
Ex.
1. "git push %s %s" % (PUSH_REMOTE_NAME, rc_tag) --> "Old Style"
2. "git push {} {}".format(PUSH_REMOTE_NAME, rc_tag) --> "New Style"
3. f"git push {PUSH_REMOTE_NAME} {rc_tag}" --> From 3.6 onwards, Python
supports string interpolation and is preferred mehtod to format string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
