mimaison commented on code in PR #13842: URL: https://github.com/apache/kafka/pull/13842#discussion_r1267863457
########## refresh-collaborators.py: ########## @@ -35,7 +36,10 @@ contributors_login_to_commit_volume = {} end_date = datetime.now() start_date = end_date - timedelta(days=365) +repo = g.get_repo("apache/kafka") for commit in repo.get_commits(since=start_date, until=end_date): + if commit.author is None and commit.author.login is None: Review Comment: This should be `or` instead of `and`, both conditions will never be true together -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org