jolshan commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1268526325
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -386,6 +386,18 @@ public short groupMetadataValueVersion() {
}
}
+ public short offsetCommitValueVersion() {
+ if (isLessThan(MetadataVersion.IBP_2_1_IV0)) {
+ return 1;
+ } else if (isLessThan(MetadataVersion.IBP_2_1_IV1)) {
+ return 2;
+ } else {
+ // Serialize with the highest supported non-flexible version
+ // until a tagged field is introduced or the version is bumped.
+ return 3;
+ }
Review Comment:
Also do we expect to have lower IBPs if this is used for the new group
coordinator? I didn't think we could go that low for kraft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
