gharris1727 commented on PR #14055:
URL: https://github.com/apache/kafka/pull/14055#issuecomment-1642919694

   Here's an example error log output when in HYBRID_FAIL mode (I shortened the 
listing for brevity; the actual prints include every non-migrated plugin)
   ```
   Plugins are missing ServiceLoader manifests, these plugins will not be 
visible with plugin.discovery=SERVICE_LOAD: [
   classpath    org.apache.kafka.connect.converters.ByteArrayConverter  
undefined
   classpath    org.apache.kafka.connect.converters.DoubleConverter     
undefined
   classpath    org.apache.kafka.connect.converters.FloatConverter      
undefined
   classpath    org.apache.kafka.connect.converters.IntegerConverter    
undefined
   classpath    org.apache.kafka.connect.converters.LongConverter       
undefined
   classpath    org.apache.kafka.connect.converters.ShortConverter      
undefined
   classpath    
org.apache.kafka.connect.integration.BlockingConnectorTest$BlockingConnector    
0.0.0
   classpath    
org.apache.kafka.connect.integration.BlockingConnectorTest$BlockingSinkConnector
        0.0.0
   ...
   classpath    org.apache.kafka.connect.transforms.predicates.TopicNameMatches 
undefined
   ]
        at 
app//org.apache.kafka.connect.runtime.isolation.Plugins.maybeReportHybridDiscoveryIssue(Plugins.java:131)
        at 
app//org.apache.kafka.connect.runtime.isolation.Plugins.initLoaders(Plugins.java:92)
        at 
app//org.apache.kafka.connect.runtime.isolation.Plugins.<init>(Plugins.java:74)
        at 
app//org.apache.kafka.connect.runtime.isolation.Plugins.<init>(Plugins.java:64)
        at 
app//org.apache.kafka.connect.cli.AbstractConnectCli.startConnect(AbstractConnectCli.java:121)
        at 
app//org.apache.kafka.connect.util.clusters.WorkerHandle.start(WorkerHandle.java:50)
        at 
app//org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster.addWorker(EmbeddedConnectCluster.java:187)
        at 
app//org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster.startConnect(EmbeddedConnectCluster.java:283)
        at 
app//org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster.start(EmbeddedConnectCluster.java:148)
        ...
        (test suite)
   ```
   
   This is what appears if the manifests included in this PR are not present.
   
   The same, but with HYBRID_WARN:
   ```
   [2023-07-19 17:03:44,143] WARN Plugins are missing ServiceLoader manifests, 
these plugins will not be visible with plugin.discovery=SERVICE_LOAD: [
   classpath    org.apache.kafka.connect.converters.ByteArrayConverter  
undefined
   ...
   classpath    org.apache.kafka.connect.transforms.predicates.TopicNameMatches 
undefined
   ] (org.apache.kafka.connect.runtime.isolation.Plugins:128)
   ```
   
   I did notice that if logging is OFF or ERROR for the runtime (such as in the 
mirror tests) then the warning doesn't print if the caller overrides the 
configuration. The failure does propagate, so they will certainly see that in 
HYBRID_FAIL.
   
   I'm going to push the required manifests, so just delete/revert them if 
you'd like to see these errors on the classpath.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to