satishd commented on code in PR #14045: URL: https://github.com/apache/kafka/pull/14045#discussion_r1269184601
########## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ########## @@ -353,4 +358,10 @@ public void close() { } } } + + public Set<TopicPartition> metadataPartitionsAssigned() { + return assignedMetaPartitions.stream() Review Comment: Can we return an immutable `Set` of `assignedMetaPartitions` instead of topic-partitions as the topic names are repetitive? This is currently being passed to build a string of partitions in an Exception message [here](https://github.com/apache/kafka/pull/14045/files#diff-7d10de4e1fdb683a452acb203d1ee92b64539a2b0b19533a6abc42fa97b2f04aR115). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org