jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270939083
########## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ########## @@ -5524,5 +5670,2897 @@ private static Record newGroupMetadataRecord( ) ); } + + @Test + public void testNewMemberTimeoutCompletion() throws Exception { + GroupMetadataManagerTestContext context = new GroupMetadataManagerTestContext.Builder() + .build(); + GenericGroup group = context.createGenericGroup("group-id"); + + JoinGroupRequestData joinRequest = new JoinGroupRequestBuilder() + .withGroupId("group-id") + .withMemberId(UNKNOWN_MEMBER_ID) + .withDefaultProtocolTypeAndProtocols() + .withSessionTimeoutMs(context.genericGroupNewMemberJoinTimeoutMs + 5000) + .build(); + + CompletableFuture<JoinGroupResponseData> joinFuture = new CompletableFuture<>(); + CoordinatorResult<Void, Record> result = context.sendGenericGroupJoin(joinRequest, joinFuture); + assertTrue(result.records().isEmpty()); + assertFalse(joinFuture.isDone()); + + context.sleepAndAssertEmptyResult(context.genericGroupInitialRebalanceDelayMs); Review Comment: thanks. did not refactor existing tests. updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org