[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

[via GitHub]

dajac commented on code in PR #14067:
URL: https://github.com/apache/kafka/pull/14067#discussion_r1273249691


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -471,9 +472,48 @@ public CompletableFuture<OffsetCommitResponseData> 
commitOffsets(
             return 
FutureUtils.failedFuture(Errors.COORDINATOR_NOT_AVAILABLE.exception());
         }
 
-        return FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception(
-            "This API is not implemented yet."
-        ));
+        if (request.groupId() == null) {
+            return 
CompletableFuture.completedFuture(OffsetCommitRequest.getErrorResponse(
+                request,
+                Errors.INVALID_GROUP_ID
+            ));
+        }

Review Comment:
   Added: 
   ```
   // For backwards compatibility, we support offset commits for the empty 
groupId.
   ```
   
   I think that we can add the same to `DescribeGroups and DeleteGroups` but we 
don't have to mention the here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org