gharris1727 commented on code in PR #14089:
URL: https://github.com/apache/kafka/pull/14089#discussion_r1273845134
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginDesc.java:
##########
@@ -115,6 +115,10 @@ public int compareTo(PluginDesc<T> other) {
int versionComp = encodedVersion.compareTo(other.encodedVersion);
// isolated plugins appear after classpath plugins when they have
identical versions.
int isolatedComp = Boolean.compare(other.loader instanceof
PluginClassLoader, loader instanceof PluginClassLoader);
- return nameComp != 0 ? nameComp : (versionComp != 0 ? versionComp :
isolatedComp);
+ // choose an arbitrary order between different classloaders and types
+ int loaderComp = loader.hashCode() - other.loader.hashCode();
Review Comment:
I've replaced this with a comparison of the locations, and tweaked some
signatures to try to enforce that Paths (and thus locations) are unique.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
