showuon commented on code in PR #14049:
URL: https://github.com/apache/kafka/pull/14049#discussion_r1274883826
##########
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java:
##########
@@ -201,4 +201,13 @@ void onPartitionLeadershipChanges(Set<TopicIdPartition>
leaderPartitions,
* @param partitions topic partitions that have been stopped.
*/
void onStopPartitions(Set<TopicIdPartition> partitions);
+
+ /**
+ * Returns total size of the log for the given leader epoch in remote
storage.
+ *
+ * @param topicPartition topic partition for which size needs to be
calculated.
+ * @param leaderEpoch Size will only include segments belonging to this
epoch.
+ * @return Total size of the log stored in remote storage in bytes.
+ */
+ Long remoteLogSize(TopicIdPartition topicPartition, int leaderEpoch)
throws RemoteStorageException;
Review Comment:
+1 to change it in subsequent commits + update the KIP.
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##########
@@ -327,6 +327,17 @@ public void onStopPartitions(Set<TopicIdPartition>
partitions) {
}
}
+ @Override
+ public Long remoteLogSize(TopicIdPartition topicPartition, int
leaderEpoch) throws RemoteStorageException {
+ long remoteLogSize = 0L;
+ Iterator<RemoteLogSegmentMetadata> remoteLogSegmentMetadataIterator =
remotePartitionMetadataStore.listRemoteLogSegments(topicPartition, leaderEpoch);
Review Comment:
I didn't see the comment you added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
