dajac commented on code in PR #14056:
URL: https://github.com/apache/kafka/pull/14056#discussion_r1276310475
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -347,9 +369,29 @@ public CompletableFuture<HeartbeatResponseData> heartbeat(
return
FutureUtils.failedFuture(Errors.COORDINATOR_NOT_AVAILABLE.exception());
}
- return FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception(
- "This API is not implemented yet."
- ));
+ if (!isGroupIdNotEmpty(request.groupId())) {
+ return CompletableFuture.completedFuture(new
HeartbeatResponseData()
+ .setErrorCode(Errors.INVALID_GROUP_ID.code()));
+ }
+
+ return runtime.scheduleReadOperation("generic-group-heartbeat",
Review Comment:
Could we also add a comment explaining why using a read operation is fine
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
