rondagostino commented on code in PR #14084:
URL: https://github.com/apache/kafka/pull/14084#discussion_r1276607523


##########
tests/kafkatest/version.py:
##########
@@ -252,3 +252,7 @@ def get_version(node=None):
 V_3_5_0 = KafkaVersion("3.5.0")
 V_3_5_1 = KafkaVersion("3.5.1")
 LATEST_3_5 = V_3_5_1
+
+# 3.6.x versions
+V_3_6_0 = KafkaVersion("3.6.0")
+LATEST_3_6 = V_3_6_0

Review Comment:
   Seems odd to add this now since, as pointed out in 
https://github.com/apache/kafka/pull/13654#discussion_r1270835742, it won't be 
used.  Seems this makes most sense to add when we bump `__version__ = 
'3.7.0.dev0'` in `tests/kafkatest/__init__.py`.
   
   To be clear (and to reiterate what is mentioned in that linked comment), it 
doesn't hurt to add this.  But I'm wondering if I'm missing something since you 
decided to add it back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to