amangandhi94 opened a new pull request, #14119:
URL: https://github.com/apache/kafka/pull/14119

   This change ensures that values stored in "non-primary" synonyms is 
respected when altering configs. Currently if "non-primary" synonyms have a 
static config set up then it gets deleted from the default log config during 
reconfiguration. We want to ensure that we retain the correct order of using 
broker level synonyms(log.retention.ms > log.retention.minutes > 
log.retention.hours)
   
   I have added unit test cases for this scenario.
   1. During setup we configure log.roll.hours=24
   2. We then run a few alter configs and ensure that LogConfig for segment.ms 
is still set to 24 hours
   3. We then run alter-config to set log.roll.ms=50000 and we verify that 
segment.ms also changes to 50000
   4. We then delete the dynamic config for log.roll.ms and then verify that we 
again pick up the statically configured 24 hour value
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to