dajac commented on code in PR #14121:
URL: https://github.com/apache/kafka/pull/14121#discussion_r1277803779
##########
examples/src/main/java/kafka/examples/Consumer.java:
##########
@@ -157,9 +157,4 @@ public void onPartitionsRevoked(Collection<TopicPartition>
partitions) {
public void onPartitionsAssigned(Collection<TopicPartition> partitions) {
Utils.printOut("Assigned partitions: %s", partitions);
}
-
- @Override
- public void onPartitionsLost(Collection<TopicPartition> partitions) {
- Utils.printOut("Lost partitions: %s", partitions);
Review Comment:
In my opinion, if you want to do something like that, it would be better to
do it for all callbacks then. Adding just one comment there is not an ideal end
state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
