nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1658638517
Hello @mimaison > If you can think of ways to split it in at least 2 PRs that would be preferable My plan is the following: 1. PR to rewrite AdminUtils - https://github.com/apache/kafka/pull/14096 . It independent from the others and can be reviewed right now. I checked all tests failures and it seems like all of them is just flacky tests from trunk. Can you, please, join the review? 2. PR to create a copy of POJOs and custom exceptions of `ReassignPartitionsCommand`. 3. PR to rewrite command itself and it's tests. To finish all three I need to rewrite `ReassignPartitionsIntegrationTest` which I do right now. I will split PR in three after it. What do you think? Can you start review of #14096 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
