showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1280542403
##########
core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java:
##########
@@ -179,6 +180,7 @@ public ReplicaManager build() {
if (metadataCache == null) throw new RuntimeException("You must set
metadataCache");
if (logDirFailureChannel == null) throw new RuntimeException("You must
set logDirFailureChannel");
if (alterPartitionManager == null) throw new RuntimeException("You
must set alterIsrManager");
+ if (brokerTopicStats == null) brokerTopicStats = new
BrokerTopicStats(Option.apply(config));
Review Comment:
Since we're moving to java now, it makes sense to use `optional`. PR updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
