divijvaidya commented on code in PR #13260:
URL: https://github.com/apache/kafka/pull/13260#discussion_r1280597042
##########
build.gradle:
##########
@@ -893,6 +893,10 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module: 'log4j'
+ // ZooKeeper moved from log4j to logback in v3.8.0,
+ // but Kafka relies on log4j. We are removing this additional dependency.
+ exclude module: 'logback-classic'
+ exclude module: 'logback-core'
}
// ZooKeeperMain depends on commons-cli but declares the dependency as
`provided`
Review Comment:
Is this still true with the latest release? (I guess not since commons-cli
is explicitly pulled as a dependency of Zk)
##########
build.gradle:
##########
@@ -893,6 +893,10 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module: 'log4j'
+ // ZooKeeper moved from log4j to logback in v3.8.0,
+ // but Kafka relies on log4j. We are removing this additional dependency.
Review Comment:
> but Kafka relies on log4j
this is not correct. Kafka uses slf4j APIs with reload4j as the logging
framework. I would suggest to rephrase this as "Zookeeper uses logback as the
logging framework but Kafka uses reload4j, hence we want to avoid having
multiple frameworks in dependency chain, so removing logback".
Next, can you check why Zk logs are working even if we are using reload4j at
runtime? (the answer might be that Zk uses slf4j and underlying framework is
pluggable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
