kamalcph commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1280887247
########## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ########## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) { public static class RemoteLogConfig { Review Comment: We cannot refer KafkaConfig from LogConfig class. Filed KAFKA-15290 to initialise/stop the remote log components for a topic when `remote.storage.enable` is set to true/false. In [TopicConfigHandler](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ConfigHandler.scala#L55C13-L55C13), we can add this validation but the config might already saved in the ConfigRepository. Do you have suggestion on how to add this validation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org