philipnee commented on code in PR #14123:
URL: https://github.com/apache/kafka/pull/14123#discussion_r1281412776
##########
core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:
##########
@@ -35,8 +39,12 @@ class BaseAsyncConsumerTest extends AbstractConsumerTest {
consumer.commitAsync(cb)
waitUntilTrue(() => {
cb.successCount == 1
- }, "wait until commit is completed successfully", 5000)
+ }, "wait until commit is completed successfully",
defaultBlockingAPITimeoutMs)
+ val committedOffset = consumer.committed(Set(tp).asJava,
Duration.ofMillis(defaultBlockingAPITimeoutMs))
+
assertTrue(consumer.assignment.contains(tp))
+ assertNotNull(committedOffset)
+ assertNull(committedOffset.get(tp))
Review Comment:
In this test, we aren't committing any offset, so the actual return of the
commit response looks like this:
(same for both old and the async one) `{topic-0=null}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
