ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1281646428
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -572,6 +573,9 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
} else {
logger.debug("Skipping copying segments, current
read-offset:{}, and LSO:{}", copiedOffset, lso);
}
+ } catch (CustomMetadataSizeLimitExceededException e) {
+ // Only stop this task. Logging is done where the exception is
thrown.
+ this.cancel();
Review Comment:
Yes, good point. I also added metrics check in
`testCustomMetadataSizeExceedsLimit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
