[GitHub] [kafka] divijvaidya commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

[via GitHub]

divijvaidya commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1252989860


##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -615,6 +661,9 @@ public void run() {
             try {
                 Optional<UnifiedLog> unifiedLogOptional = 
fetchLog.apply(topicIdPartition.topicPartition());
 
+                // CleanUp/delete deleted remote log segments
+                cleanupDeletedRemoteLogSegments();

Review Comment:
   we do not want to block the existing archival to clean up the deleted 
segments. Clean up for deletion should be done asynchronously with 
RemotePartitionRemover as specific by KIP-405.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org