divijvaidya commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1282856425
##########
core/src/test/scala/integration/kafka/api/MetricsTest.scala:
##########
@@ -54,6 +57,12 @@ class MetricsTest extends IntegrationTestHarness with
SaslSetup {
@BeforeEach
override def setUp(testInfo: TestInfo): Unit = {
+ if (testInfo.getDisplayName.endsWith("true")) {
Review Comment:
Wouldn't this enable RemoteStorage for all tests which use `@Parameterized`
(and not just for testMetrics)? An alternative way is to add the full test name
here OR check for string "systemRemoteStorageEnabled: true".
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -122,8 +123,6 @@ public class RemoteLogManager implements Closeable {
private static final Logger LOGGER =
LoggerFactory.getLogger(RemoteLogManager.class);
private static final String REMOTE_LOG_READER_THREAD_NAME_PREFIX =
"remote-log-reader";
Review Comment:
shouldn't this go to RemoteStorageMetrics as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
