satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1283024088
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -618,6 +625,230 @@ public void run() {
}
}
+ public void handleLogStartOffsetUpdate(TopicPartition topicPartition,
long remoteLogStartOffset) {
+ if (isLeader()) {
Review Comment:
It is not mandatory to update it when this node becomes a follower as the
existing follower fetch protocol makes sure that the follower truncates their
log-start-offset based on the leader's log-start-ffset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
