kamalcph commented on PR #14116: URL: https://github.com/apache/kafka/pull/14116#issuecomment-1668144105
> This leads to a situation where the tests we add will not be runnable with kraft/zk mode easily. We are not using ZooKeeper client directly anywhere so Kraft mode should work as expected. > My main concern is that we are using IntegrationTestHarness but duplicating a lot of it's code in our own implementation in TieredStorageContext Agree, there are some code duplications but it gives us flexibility to reuse the client which avoids log pollution while debugging a failed test. > unnecessary specs and actions Plan is to add respective tests such as ReassignReplicaShrinkTest, ReassignReplicaExpandTest, ReassignReplicaMoveTest, PartitionsExpandTest, DeleteSegmentsByRetentionTimeTest, ListOffsetsTest and so on once the build becomes stable. We can remove the unused actions if required. Thanks for reviewing the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
