lucasbru commented on code in PR #14001:
URL: https://github.com/apache/kafka/pull/14001#discussion_r1286114522
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##########
@@ -86,12 +87,29 @@ private void runOnce(final long nowMs) {
if (currentTask == null) {
currentTask =
taskManager.assignNextTask(DefaultTaskExecutor.this);
- } else {
- // if a task is no longer processable, ask task-manager to
give it another
- // task in the next iteration
- if (currentTask.isProcessable(nowMs)) {
+ }
+
+ if (currentTask != null) {
Review Comment:
Hmm, that's a good point! Not sure if I'm worried about getting back null
(we still need the check even with a condition variable), but it'd be good to
avoid busy waiting. But we still want to shut-down cleanly, so we still want to
check isRunning and isPaused as well...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
