AndrewJSchofield commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1286838977
##########
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##########
@@ -144,13 +159,25 @@ public long metadataExpireMs() {
*/
public synchronized int requestUpdate() {
this.needFullUpdate = true;
+ this.backoffUpdateRequests = 0L;
Review Comment:
Yes. There are many routes to requesting metadata update. Some of them
obviously are retrying and applying backoff makes sense. Some of them just want
metadata immediately. What I'm trying to do is to introduce backoff in
situations in which metadata requests are issued repeatedly because of an error
result. But a single Metadata can be used by a client which has a lot going on,
and I'm trying to make sure that I only back off when I'm sure it's appropriate.
Personally, I would like to see this entire area refactored one day so that
metadata is a more granular affair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
