bachmanity1 commented on code in PR #14153:
URL: https://github.com/apache/kafka/pull/14153#discussion_r1287236551
##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java:
##########
@@ -114,29 +113,49 @@ public class KafkaBasedLogTest {
private static final String TP0_VALUE_NEW = "VAL0_NEW";
private static final String TP1_VALUE_NEW = "VAL1_NEW";
- private Time time = new MockTime();
- private KafkaBasedLog<String, String> store;
+ private final Time time = new MockTime();
+ private MockedKafkaBasedLog store;
@Mock
- private Runnable initializer;
+ private Consumer<TopicAdmin> initializer;
@Mock
private KafkaProducer<String, String> producer;
- private MockConsumer<String, String> consumer;
- @Mock
Review Comment:
`admin` field needs to be mocked only in methods where previously
`setupWithAdmin` was used, if we mock it everywhere then some tests don't pass
because they expect that `admin` is `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
