dengziming commented on code in PR #14110:
URL: https://github.com/apache/kafka/pull/14110#discussion_r1287875933
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -2354,6 +2354,75 @@ public void testDeleteRecords() throws Exception {
}
}
+ @Test
+ public void testDescribeTopicsByIds() {
+ try (AdminClientUnitTestEnv env = mockClientEnv()) {
+ env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
+
+ // Valid ID
+ Uuid topicId = Uuid.randomUuid();
+ String topicName = "test-topic";
+ Node leader = env.cluster().nodes().get(0);
+ MetadataResponse.PartitionMetadata partitionMetadata = new
MetadataResponse.PartitionMetadata(
+ Errors.NONE,
+ new TopicPartition(topicName, 0),
+ Optional.of(leader.id()),
+ Optional.of(10),
+ singletonList(leader.id()),
+ singletonList(leader.id()),
+ singletonList(leader.id()));
+ env.kafkaClient().prepareResponse(RequestTestUtils
+ .metadataResponse(
+ env.cluster().nodes(),
+ env.cluster().clusterResource().clusterId(),
+ env.cluster().controller().id(),
+ singletonList(new
MetadataResponse.TopicMetadata(Errors.NONE, topicName, topicId, false,
+ singletonList(partitionMetadata),
MetadataResponse.AUTHORIZED_OPERATIONS_OMITTED))));
+ TopicCollection.TopicIdCollection topicIds =
TopicCollection.ofTopicIds(
+ singletonList(topicId));
+ try {
+ DescribeTopicsResult result =
env.adminClient().describeTopics(topicIds);
+ Map<Uuid, TopicDescription> allTopicIds =
result.allTopicIds().get();
+ assertEquals(topicName, allTopicIds.get(topicId).name());
+ } catch (Exception e) {
+ fail("describe with valid topicId should not fail", e);
+ }
+
+ // ID not exist in brokers
+ Uuid nonExistID = Uuid.randomUuid();
+ env.kafkaClient().prepareResponse(RequestTestUtils
+ .metadataResponse(
+ env.cluster().nodes(),
+ env.cluster().clusterResource().clusterId(),
+ env.cluster().controller().id(),
+ asList()));
Review Comment:
It's better to use emptyList()
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -2354,6 +2354,75 @@ public void testDeleteRecords() throws Exception {
}
}
+ @Test
+ public void testDescribeTopicsByIds() {
+ try (AdminClientUnitTestEnv env = mockClientEnv()) {
+ env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
+
+ // Valid ID
+ Uuid topicId = Uuid.randomUuid();
+ String topicName = "test-topic";
+ Node leader = env.cluster().nodes().get(0);
+ MetadataResponse.PartitionMetadata partitionMetadata = new
MetadataResponse.PartitionMetadata(
+ Errors.NONE,
+ new TopicPartition(topicName, 0),
+ Optional.of(leader.id()),
+ Optional.of(10),
+ singletonList(leader.id()),
+ singletonList(leader.id()),
+ singletonList(leader.id()));
+ env.kafkaClient().prepareResponse(RequestTestUtils
+ .metadataResponse(
+ env.cluster().nodes(),
+ env.cluster().clusterResource().clusterId(),
+ env.cluster().controller().id(),
+ singletonList(new
MetadataResponse.TopicMetadata(Errors.NONE, topicName, topicId, false,
+ singletonList(partitionMetadata),
MetadataResponse.AUTHORIZED_OPERATIONS_OMITTED))));
+ TopicCollection.TopicIdCollection topicIds =
TopicCollection.ofTopicIds(
+ singletonList(topicId));
+ try {
+ DescribeTopicsResult result =
env.adminClient().describeTopics(topicIds);
+ Map<Uuid, TopicDescription> allTopicIds =
result.allTopicIds().get();
+ assertEquals(topicName, allTopicIds.get(topicId).name());
+ } catch (Exception e) {
+ fail("describe with valid topicId should not fail", e);
+ }
+
+ // ID not exist in brokers
+ Uuid nonExistID = Uuid.randomUuid();
+ env.kafkaClient().prepareResponse(RequestTestUtils
+ .metadataResponse(
+ env.cluster().nodes(),
+ env.cluster().clusterResource().clusterId(),
+ env.cluster().controller().id(),
+ asList()));
+ try {
+ DescribeTopicsResult result = env.adminClient().describeTopics(
+ TopicCollection.ofTopicIds(singletonList(nonExistID)));
+ TestUtils.assertFutureError(result.allTopicIds(),
InvalidTopicException.class);
+ result.allTopicIds().get();
+ fail("describe with non-exist topic ID should throw
exception");
+ } catch (Exception e) {
+ assertEquals(
+
String.format("org.apache.kafka.common.errors.InvalidTopicException: TopicId %s
not found.", nonExistID),
Review Comment:
I think we are supposed to get a UnknownTopicIdException in this case, but
it's not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
