fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1287993847
########## core/src/main/scala/kafka/tools/GetOffsetShell.scala: ########## Review Comment: > We should still keep this file can forward all args to new GetOffsetShell, see `FeatureCommand.scala`. Hi @dengziming, this is tool was reported in the "missing wrapper script" category in [KIP-906](https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines), but that was only because some system tests are depending on the FQCN. In this PR we are also changing that, and they are now using the wrapper script instead, so I think there is no need for the redirection. ########## core/src/main/scala/kafka/tools/GetOffsetShell.scala: ########## Review Comment: Hi @dengziming, this is tool was reported in the "missing wrapper script" category in [KIP-906](https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines), but that was only because some system tests are depending on the FQCN. In this PR we are also changing that, and they are now using the wrapper script instead, so I think there is no need for the redirection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
