nizhikov commented on code in PR #14172: URL: https://github.com/apache/kafka/pull/14172#discussion_r1288443925
########## tools/src/main/java/org/apache/kafka/tools/reassign/ActiveMoveState.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.tools.reassign; + +import java.util.Objects; + +/** + * A replica log directory move state where the move is in progress. + */ +final class ActiveMoveState implements LogDirMoveState { + public final String currentLogDir; + + public final String targetLogDir; + + public final String futureLogDir; + + /** + * @param currentLogDir The current log directory. + * @param futureLogDir The log directory that the replica is moving to. + * @param targetLogDir The log directory that we wanted the replica to move to. + */ + public ActiveMoveState(String currentLogDir, String targetLogDir, String futureLogDir) { + this.currentLogDir = currentLogDir; + this.targetLogDir = targetLogDir; + this.futureLogDir = futureLogDir; + } + + @Override + public boolean done() { + return false; + } + + @Override + public boolean equals(Object o) { Review Comment: Yes. It used in tests during comparsion when POJOs are keys or values of collection returned by tested code. Examples: ``` class ReassignPartitionsUnitTest { ... @Test def testFindPartitionReassignmentStates(): Unit = { ... assertEquals((Map( new TopicPartition("foo", 0) -> PartitionReassignmentState(Seq(0,1,2), Seq(0,1,3), false), new TopicPartition("foo", 1) -> PartitionReassignmentState(Seq(1,2,3), Seq(1,2,3), true) ), true), findPartitionReassignmentStates(adminClient, Seq( (new TopicPartition("foo", 0), Seq(0,1,3)), (new TopicPartition("foo", 1), Seq(1,2,3)) ))) ... @Test def testFindLogDirMoveStates(): Unit = { ... assertEquals(Map( new TopicPartitionReplica("bar", 0, 0) -> new CompletedMoveState("/tmp/kafka-logs0"), new TopicPartitionReplica("foo", 0, 0) -> new ActiveMoveState("/tmp/kafka-logs0", "/tmp/kafka-logs1", "/tmp/kafka-logs1"), new TopicPartitionReplica("foo", 1, 0) -> new CancelledMoveState("/tmp/kafka-logs0", "/tmp/kafka-logs1"), new TopicPartitionReplica("quux", 1, 0) -> new MissingLogDirMoveState("/tmp/kafka-logs1"), new TopicPartitionReplica("quuz", 0, 0) -> new MissingReplicaMoveState("/tmp/kafka-logs0") ), findLogDirMoveStates(adminClient, Map( new TopicPartitionReplica("bar", 0, 0) -> "/tmp/kafka-logs0", new TopicPartitionReplica("foo", 0, 0) -> "/tmp/kafka-logs1", new TopicPartitionReplica("foo", 1, 0) -> "/tmp/kafka-logs1", new TopicPartitionReplica("quux", 1, 0) -> "/tmp/kafka-logs1", new TopicPartitionReplica("quuz", 0, 0) -> "/tmp/kafka-logs0" ))) ... ``` ########## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple.java: ########## @@ -0,0 +1,48 @@ +/* Review Comment: Removed ########## tools/src/main/java/org/apache/kafka/tools/reassign/TerseReassignmentFailureException.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.tools.reassign; + +import org.apache.kafka.common.KafkaException; + +/** + * An exception thrown to indicate that the command has failed, but we don't want to + * print a stack trace. + */ +public class TerseReassignmentFailureException extends KafkaException { Review Comment: It seems that we can reuse existing class. Scala version of command use explicit class so I move it as is. Exception removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
