[ 
https://issues.apache.org/jira/browse/KAFKA-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752510#comment-17752510
 ] 

Divij Vaidya commented on KAFKA-15224:
--------------------------------------

> can we include new python packages?

Sure. Currently the expectation if for release manager to manually set up the 
dependencies in the machine that they will use to build the release. You will 
find the release process here and observe manual instructions such as  "Make 
sure you're running the script with Python3" or install "$pip3 install jira". 
Please feel free to add requirements.txt, in fact, that is I believe the 
preferred approach. Perhaps create a release folder and move release.py, 
requirements.txt and other new python scripts that we may create in that folder.

> in the example PR, there are files with version bump without `SNAPSHOT` 
> suffix. Would this script update files with `\{version}-SNAPSHOT` always

No, not always. As an example you will notice that we don't add "SNAPSHOT" 
suffix to fullDotVersion.js file. We run the set of commands in this PR when 
release is done for existing version and we want to prepare branch for next 
version (hence calling it snapshot). Note that we do inverse of this operations 
(removing snapshot) at 
[https://github.com/apache/kafka/blob/trunk/release.py#L559-L577.] We do the 
inverse prior to the release.

Does these answer your questions?

> Automate version change to snapshot 
> ------------------------------------
>
>                 Key: KAFKA-15224
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15224
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Divij Vaidya
>            Assignee: Tanay Karmarkar
>            Priority: Minor
>
> We require changing to SNAPSHOT version as part of the release process [1]. 
> The specific manual steps are:
> Update version on the branch to 0.10.0.1-SNAPSHOT in the following places:
>  * 
>  ** docs/js/templateData.js
>  ** gradle.properties
>  ** kafka-merge-pr.py
>  ** streams/quickstart/java/pom.xml
>  ** streams/quickstart/java/src/main/resources/archetype-resources/pom.xml
>  ** streams/quickstart/pom.xml
>  ** tests/kafkatest/_{_}init{_}_.py (note: this version name can't follow the 
> -SNAPSHOT convention due to python version naming restrictions, instead
> update it to 0.10.0.1.dev0)
>  ** tests/kafkatest/version.py
> The diff of the changes look like 
> [https://github.com/apache/kafka/commit/484a86feb562f645bdbec74b18f8a28395a686f7#diff-21a0ab11b8bbdab9930ad18d4bca2d9435555bbdf40d29d68ab8a96f765bd1f9]
>  
>  
> It would be nice if we could run a script to automatically do it. Note that 
> release.py (line 550) already does something similar where it replaces 
> SNAPSHOT with actual version. We need to do the opposite here. We can 
> repurpose that code in release.py and extract into a new script to perform 
> this opertaion.
> [1] [https://cwiki.apache.org/confluence/display/KAFKA/Release+Process]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to