junrao commented on PR #13947: URL: https://github.com/apache/kafka/pull/13947#issuecomment-1672284941
> I didn't follow previous changes, but I think current implementation also works for KRaft mode, right? I can see ReplicaManager#applyDelta is invoking stopPartitions, which will do what we expect. Is my understanding correct? @showuon : It seems the latest PR still doesn't support KRaft. The issue is that `ReplicaManager#applyDelta` is invoking a version of `stopPartitions()` that always sets `StopPartition.deleteRemoteLog` to false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
