mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290489338


##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -718,6 +760,24 @@ <h4><a class="toc-backref" 
href="#id34">rack.aware.assignment.tags</a><a class="
             </p>
           </div>
         </blockquote>
+      </div>
+      <div class="section" id="rack-aware-assignment-traffic-cost">
+        <h4><a class="toc-backref" 
href="#id36">rack.aware.assignment.traffic_cost</a><a class="headerlink" 
href="#rack-aware-assignment-traffic-cost" title="Permalink to this 
headline"></a></h4>
+        <blockquote>
+          <div>
+            <p>
+              This configuration sets the cost of cross rack traffic. Together 
with <code class="docutils literal"><span 
class="pre">rack.aware.assignment.non_overlap_cost</span></code>,
+              they control whether the optimizer favors minimizing cross rack 
traffic or minimizing the movement of tasks in the existing assignment. If this 
config is set to a larger value than <code class="docutils literal"><span 
class="pre">rack.aware.assignment.non_overlap_cost</span></code>,
+              the optimizer will try to compute an assignment which minimize 
the cross rack traffic. Note that the optimizer takes the ratio of these two 
configs into consideration of favoring maintaining existing assignment or 
minimizing traffic cost. For example, setting
+              <code class="docutils literal"><span 
class="pre">rack.aware.assignment.traffic_cost</span></code> to 10 and <code 
class="docutils literal"><span 
class="pre">rack.aware.assignment.non_overlap_cost</span></code> to 1 is more 
likely to minimize cross rack traffic than setting
+              <code class="docutils literal"><span 
class="pre">rack.aware.assignment.traffic_cost</span></code> to 100 and <code 
class="docutils literal"><span 
class="pre">rack.aware.assignment.non_overlap_cost</span></code> to 50.
+            </p>
+            <p>
+              The default value is null which means default traffic cost in 
different assignors will be used. In <code class="docutils literal"><span 
class="pre">StickyTaskAssignor</span></code>, it has a lower default value than 
<code class="docutils literal"><span 
class="pre">rack.aware.assignment.non_overlap_cost</span></code>.

Review Comment:
   As above: include default value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to