jolshan commented on code in PR #14138:
URL: https://github.com/apache/kafka/pull/14138#discussion_r1290546194


##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -798,6 +803,12 @@ class Partition(val topicPartition: TopicPartition,
       // to maintain the decision maker controller's epoch in the zookeeper 
path
       controllerEpoch = partitionState.controllerEpoch
 
+      val isNewLeaderEpoch = partitionState.leaderEpoch > leaderEpoch

Review Comment:
   Can we add a bit more detail in the description about why we moved this to 
be before updateAssignmentAndIsr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to