showuon commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1678365110
> Please correct me if I have understood this wrongly, but this pull request proposes propagating a configuration known only to the RemoteLogManagerConfig to the LogConfig via the KafkaConfig? If this is true, I am not certain I approve of this approach. I would argue that we need a new abstraction which compares hierarchically set values. In other parts of the codebase, for example log.segment.bytes and segment.bytes, it is the KafkaConfig which pulls values from the LogConfig rather than push them down. I would prefer that if we are keen on proceeding with adding this validation that it is added in a neutral-zone for now similar to what I did in [#14161 (comment)](https://github.com/apache/kafka/pull/14161#discussion_r1290107019). This in my head makes it very clear that we do not yet have the right abstraction for it, but we definitely do not try to nudge already existing abstractions. I agree it'd be great if we could find a neutral-zone for such validation, but it doesn't exist currently. It needs some refactor to make that happen. Before that, I think I'm in favor of current approach. I just left some more comments to try not to make the `LogConfig` lists containing `RemoteLogManagerConfig`. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
