[GitHub] [kafka] showuon commented on a diff in pull request #14202: KAFKA-15329: Make default remote.log.metadata.manager.class.name as topic based RLMM

[via GitHub]

showuon commented on code in PR #14202:
URL: https://github.com/apache/kafka/pull/14202#discussion_r1294388761


##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java:
##########
@@ -32,21 +36,28 @@ public TestConfig(Map<?, ?> originals) {
         }
     }
 
-    @Test
-    public void testValidConfigs() {
+    @ParameterizedTest
+    @ValueSource(booleans = {true, false})
+    public void testValidConfigs(boolean 
useDefaultRemoteLogMetadataManagerClass) {
         String rsmPrefix = "__custom.rsm.";
         String rlmmPrefix = "__custom.rlmm.";
         Map<String, Object> rsmProps = Collections.singletonMap("rsm.prop", 
"val");
         Map<String, Object> rlmmProps = Collections.singletonMap("rlmm.prop", 
"val");
+        String remoteLogMetadataManagerClass = 
useDefaultRemoteLogMetadataManagerClass ? 
DEFAULT_REMOTE_LOG_METADATA_MANAGER_CLASS_NAME : 
"dummy.remote.log.metadata.class";
+        System.out.println(remoteLogMetadataManagerClass);

Review Comment:
   Should be removed.



##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java:
##########
@@ -32,21 +36,28 @@ public TestConfig(Map<?, ?> originals) {
         }
     }
 
-    @Test
-    public void testValidConfigs() {
+    @ParameterizedTest
+    @ValueSource(booleans = {true, false})
+    public void testValidConfigs(boolean 
useDefaultRemoteLogMetadataManagerClass) {
         String rsmPrefix = "__custom.rsm.";
         String rlmmPrefix = "__custom.rlmm.";
         Map<String, Object> rsmProps = Collections.singletonMap("rsm.prop", 
"val");
         Map<String, Object> rlmmProps = Collections.singletonMap("rlmm.prop", 
"val");
+        String remoteLogMetadataManagerClass = 
useDefaultRemoteLogMetadataManagerClass ? 
DEFAULT_REMOTE_LOG_METADATA_MANAGER_CLASS_NAME : 
"dummy.remote.log.metadata.class";
+        System.out.println(remoteLogMetadataManagerClass);
         RemoteLogManagerConfig expectedRemoteLogManagerConfig
                 = new RemoteLogManagerConfig(true, 
"dummy.remote.storage.class", "dummy.remote.storage.class.path",
-                                             
"dummy.remote.log.metadata.class", "dummy.remote.log.metadata.class.path",
+                remoteLogMetadataManagerClass, 
"dummy.remote.log.metadata.class.path",

Review Comment:
   wrong indent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org