showuon commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1294548425


##########
storage/src/test/java/org/apache/kafka/tiered/storage/README.md:
##########
@@ -0,0 +1,9 @@
+Step 1: For every test, setup is done via TieredStorageTestHarness which 
extends IntegrationTestHarness and sets up a cluster with TS enabled on it.

Review Comment:
   Could we add some header/title above this steps? Maybe "the test flow" ?



##########
checkstyle/checkstyle.xml:
##########
@@ -119,7 +119,7 @@
     </module>
     <module name="ClassDataAbstractionCoupling">
       <!-- default is 7 -->
-      <property name="max" value="25"/>
+      <property name="max" value="40"/>

Review Comment:
   Could we suppress it when needed instead of changing the global setting?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to