pprovenzano commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1296013735
##########
core/src/main/scala/kafka/server/DelegationTokenManager.scala:
##########
@@ -257,6 +153,13 @@ class DelegationTokenManager(val config: KafkaConfig,
scramCredentialMap.toMap
}
+ /**
+ * @param token
+ */
+ def updateToken(token: DelegationToken): Unit = {
Review Comment:
> Should we protect this as well with the lock? The ZK variant is protected
through the create/renew/expire methods but this isn't. (As I see we only use
it through `DelegationTokenPublisher.onMetadataUpdate` but I don't know if
calls to that come from multiple threads or just a single one.)
The calls come from just a single thread. They have to because replay of
records out of order could lead to inconsistent state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
