kamalcph commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1296359728


##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##########
@@ -166,6 +166,10 @@ public Cache<Uuid, Entry> internalCache() {
         return internalCache;
     }
 
+    public void remove(Uuid key) {

Review Comment:
   Should we take read/write lock? Read lock can be held by multiple threads so 
took the write lock instead. Also, added one method to invalidate a collection 
of keys.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to