pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1296572585
########## metadata/src/test/java/org/apache/kafka/image/DelegationTokenImageTest.java: ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.image; + +import org.apache.kafka.common.metadata.DelegationTokenRecord; +import org.apache.kafka.common.metadata.RemoveDelegationTokenRecord; +import org.apache.kafka.common.security.auth.KafkaPrincipal; +import org.apache.kafka.common.security.token.delegation.TokenInformation; +import org.apache.kafka.common.utils.SecurityUtils; +import org.apache.kafka.image.writer.ImageWriterOptions; +import org.apache.kafka.image.writer.RecordListWriter; +import org.apache.kafka.metadata.RecordTestUtils; +import org.apache.kafka.metadata.DelegationTokenData; +import org.apache.kafka.server.common.ApiMessageAndVersion; +import org.apache.kafka.server.common.MetadataVersion; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.fail; + + +@Timeout(value = 40) +public class DelegationTokenImageTest { + public final static DelegationTokenImage IMAGE1; + + public final static List<ApiMessageAndVersion> DELTA1_RECORDS; + + final static DelegationTokenDelta DELTA1; + + final static DelegationTokenImage IMAGE2; + + static DelegationTokenData randomDelegationTokenData(String tokenId, long expireTimestamp) { + TokenInformation ti = new TokenInformation( + tokenId, + SecurityUtils.parseKafkaPrincipal(KafkaPrincipal.USER_TYPE + ":" + "fred"), + SecurityUtils.parseKafkaPrincipal(KafkaPrincipal.USER_TYPE + ":" + "fred"), + new ArrayList<KafkaPrincipal>(), + 0, + 1000, + expireTimestamp); + return new DelegationTokenData(ti); + } + + static { + Map<String, DelegationTokenData> image1 = new HashMap<>(); + image1.put("somerandomuuid1", randomDelegationTokenData("somerandomuuid1", 100)); + image1.put("somerandomuuid2", randomDelegationTokenData("somerandomuuid2", 100)); + image1.put("somerandomuuid3", randomDelegationTokenData("somerandomuuid3", 100)); + IMAGE1 = new DelegationTokenImage(image1); + + DELTA1_RECORDS = new ArrayList<>(); + DELTA1_RECORDS.add(new ApiMessageAndVersion(new DelegationTokenRecord(). + setOwner(KafkaPrincipal.USER_TYPE + ":" + "fred"). + setRequester(KafkaPrincipal.USER_TYPE + ":" + "fred"). + setIssueTimestamp(0). + setMaxTimestamp(1000). + setExpirationTimestamp(200). + setTokenId("somerandomuuid1"), (short) 0)); + DELTA1_RECORDS.add(new ApiMessageAndVersion(new RemoveDelegationTokenRecord(). + setTokenId("somerandomuuid3"), (short) 0)); + + DELTA1 = new DelegationTokenDelta(IMAGE1); + RecordTestUtils.replayAll(DELTA1, DELTA1_RECORDS); + + Map<String, DelegationTokenData> image2 = new HashMap<>(); + image2.put("somerandomuuid1", randomDelegationTokenData("somerandomuuid1", 200)); + image2.put("somerandomuuid2", randomDelegationTokenData("somerandomuuid2", 100)); + IMAGE2 = new DelegationTokenImage(image2); + } + + @Test + public void testEmptyImageRoundTrip() throws Throwable { + testToImageAndBack(DelegationTokenImage.EMPTY); + } + + @Test + public void testImage1RoundTrip() throws Throwable { + testToImageAndBack(IMAGE1); + } + + @Test + public void testApplyDelta1() throws Throwable { + assertEquals(IMAGE2, DELTA1.apply()); + } + + @Test + public void testImage2RoundTrip() throws Throwable { + testToImageAndBack(IMAGE2); + } + + private void testToImageAndBack(DelegationTokenImage image) throws Throwable { + RecordListWriter writer = new RecordListWriter(); + image.write(writer, new ImageWriterOptions.Builder().build()); + DelegationTokenDelta delta = new DelegationTokenDelta(DelegationTokenImage.EMPTY); + RecordTestUtils.replayAll(delta, writer.records()); + DelegationTokenImage nextImage = delta.apply(); + assertEquals(image, nextImage); + } + + @Test + public void testEmptyWithInvalidIBP() throws Throwable { Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
