rondagostino commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1298759956
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -6069,19 +6071,19 @@ class KafkaApisTest {
@Test
def testRaftShouldAlwaysForwardCreateTokenRequest(): Unit = {
metadataCache = MetadataCache.kRaftMetadataCache(brokerId)
- verifyShouldAlwaysForwardErrorMessage(createKafkaApis(raftSupport =
true).handleCreateTokenRequest)
+ verifyShouldAlwaysForwardErrorMessage(createKafkaApis(raftSupport =
true).handleCreateTokenRequestZk)
Review Comment:
I think this change is incorrect. We are checking that a KRaft broker
forwards to the KRaft controller, and {handleCreateTokenRequestZk,
handleRenewTokenRequestZk,handleExpireTokenRequestZk} aren't invoked on KRaft
brokers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
