lianetm commented on code in PR #14218:
URL: https://github.com/apache/kafka/pull/14218#discussion_r1300660815
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##########
@@ -206,46 +199,34 @@ public void run() {
* 3. Poll the networkClient to send and retrieve the response.
*/
void runOnce() {
- drain();
+ if (!applicationEventQueue.isEmpty()) {
+ LinkedList<ApplicationEvent> res = new LinkedList<>();
+ this.applicationEventQueue.drainTo(res);
+
+ for (ApplicationEvent event : res) {
+ log.debug("Consuming application event: {}", event);
+ Objects.requireNonNull(event);
+ applicationEventProcessor.process(event);
+ }
+ }
+
final long currentTimeMs = time.milliseconds();
- final long pollWaitTimeMs = requestManagerRegistry.values().stream()
+ final long pollWaitTimeMs = requestManagers.entries().stream()
.filter(Optional::isPresent)
.map(m -> m.get().poll(currentTimeMs))
+ .filter(Objects::nonNull)
Review Comment:
You're right...removing the unneeded filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
