kamalcph commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1301834895
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -500,22 +500,27 @@ public static void validateBrokerLogConfigValues(Map<?,
?> props,
* The default values should be extracted from the KafkaConfig.
* @param props The properties to be validated
*/
- private static void validateTopicLogConfigValues(Map<?, ?> props,
- boolean
isRemoteLogStorageSystemEnabled) {
+ public static void validateTopicLogConfigValues(Map<?, ?> props,
Review Comment:
can we revert the method access specifier to `private`?
##########
core/src/test/scala/unit/kafka/server/TieredStorageSystemWideConfigTest.scala:
##########
@@ -0,0 +1,100 @@
+package unit.kafka.server
+
+import kafka.integration.KafkaServerTestHarness
+import kafka.server.KafkaConfig
+import kafka.utils.{TestInfoUtils, TestUtils}
+import org.apache.kafka.common.config.{ConfigException, TopicConfig}
+import org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig
+import org.junit.jupiter.api.Assertions.{assertThrows, assertTrue}
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
+
+import java.util.Properties
+
+class TieredStorageSystemWideConfigTest extends KafkaServerTestHarness {
Review Comment:
Can we extend `IntegrationTestHarness` instead of `KafkaServerTestHarness`
and unify the test-case for both the modes similar to
[RemoteTopicCrudTest](https://github.com/apache/kafka/blob/trunk/core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala#L77)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
