jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302269425
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -480,9 +482,35 @@ public
CompletableFuture<List<OffsetFetchResponseData.OffsetFetchResponseTopics>
return
FutureUtils.failedFuture(Errors.COORDINATOR_NOT_AVAILABLE.exception());
}
- return FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception(
- "This API is not implemented yet."
- ));
+ // For backwards compatibility, we support fetch commits for the empty
groupId.
Review Comment:
Ok -- I guess I just wasn't sure if this comment and the error need to be
changed or not. Is the idea you can commit them but can't fetch them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
