gharris1727 opened a new pull request, #14278:
URL: https://github.com/apache/kafka/pull/14278

   The MirrorConnectorsIntegrationBaseTest and derived tests delete all of the 
topics after the test is complete, but before the EmbeddedConnectCluster (and 
EmbeddedKafkaCluster) are stopped. If a topic is deleted before the source task 
can stop (usually the MirrorHeartbeatTask), the task will get stuck and 
eventually be cancelled. The worker itself also appears to get stuck on 
accesses to the internal topics, which must time out before the worker will 
stop.
   
   This has the effect of making the test runtime inconsistent, and sometimes 
extremely slow. With this patch applied and a very small sample size, I saw 
speedups of up to 8x for individual test methods, and ~2x for the suite 
overall. On my machine a single suite is now <5 minutes and 
`connect:mirror:test` completes in <10 minutes.
   
   Because the EmbeddedConnectCluster is created fresh in the startClusters 
command, deleting the topics has no effect on the behavior of the tests, only 
the time it takes to clean them up. We can just eliminate the deletion step 
completely, and discard the contents of the topics by discarding the whole 
EmbeddedKafkaCluster instance.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to